[MS] User details modal #6000
Merged
[MS] User details modal #6000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ironicbay
force-pushed
the
ms-user-details-modal
branch
from
8ebd833
to
ae14741
Compare
Ironicbay
force-pushed
the
ms-user-details-modal
branch
3 times, most recently
from
dfdd86a
to
733bd52
Compare
NicoTuxx
requested changes
Dec 15, 2023
| .user-details-modal { | ||
| --width: 642px; | ||
| --height: 468px; | ||
| } |
There was a problem hiding this comment.
where is it coming from? copy/paste? is there a specific reflexion behind these values?
There was a problem hiding this comment.
These values are taken from the mockups, I was unsure if setting them explicitly was necessary or not (and now that you mention it, the height value is different in the revoked mockup so I'm guessing it's not)
There was a problem hiding this comment.
Yes in lots of cases the modal will fits its content and it will be good enough.
@fabienSvtr a thought on this?
There was a problem hiding this comment.
We need to open an issue to harmonise all modal width. For this PR you can let the specific value.
I recently updated the Figma with width variables for that.
Max-7
requested changes
Dec 18, 2023
Ironicbay
force-pushed
the
ms-user-details-modal
branch
from
395be0b
to
81af662
Compare
Max-7
requested changes
Dec 18, 2023
Max-7
reviewed
Dec 18, 2023
fabienSvtr
reviewed
Dec 18, 2023
Comment on lines
9
to
26
| <div> | ||
| <ion-text class="text1"> | ||
| {{ $t('UsersPage.UserDetailsModal.subtitles.name') }} | ||
| </ion-text> | ||
| <ion-text class="text1-right"> | ||
| {{ $t('UsersPage.UserDetailsModal.subtitles.joined') }} | ||
| </ion-text> | ||
| </div> | ||
| <div> | ||
| <ion-text class="text2"> | ||
| {{ user.humanHandle.label }} | ||
| </ion-text> | ||
| <ion-text class="text2-right"> | ||
| {{ timeSince(user.createdOn, '--', 'short') }} | ||
| </ion-text> | ||
| </div> | ||
| <div> | ||
| <ion-text class="text4"> | ||
| {{ $t('UsersPage.UserDetailsModal.subtitles.commonWorkspaces') }} | ||
| </ion-text> | ||
| </div> |
There was a problem hiding this comment.
Here the BEM suggestion.
In addition, it is preferable to group the code according to context so that each group/block can be managed (such as the user's name and title).
Suggested change
| <div> | |
| <ion-text class="text1"> | |
| {{ $t('UsersPage.UserDetailsModal.subtitles.name') }} | |
| </ion-text> | |
| <ion-text class="text1-right"> | |
| {{ $t('UsersPage.UserDetailsModal.subtitles.joined') }} | |
| </ion-text> | |
| </div> | |
| <div> | |
| <ion-text class="text2"> | |
| {{ user.humanHandle.label }} | |
| </ion-text> | |
| <ion-text class="text2-right"> | |
| {{ timeSince(user.createdOn, '--', 'short') }} | |
| </ion-text> | |
| </div> | |
| <div> | |
| <ion-text class="text4"> | |
| {{ $t('UsersPage.UserDetailsModal.subtitles.commonWorkspaces') }} | |
| </ion-text> | |
| </div> | |
| <div class="detail-name"> | |
| <ion-text class="details-name__title"> | |
| {{ $t('UsersPage.UserDetailsModal.subtitles.name') }} | |
| </ion-text> | |
| <ion-text class="detail-name__fullname"> | |
| {{ user.humanHandle.label }} | |
| </ion-text> | |
| </div> | |
| <div class="detail-joined"> | |
| <ion-text class="detail-joined__title"> | |
| {{ $t('UsersPage.UserDetailsModal.subtitles.joined') }} | |
| {{ user.humanHandle.label }} | |
| </ion-text> | |
| <ion-text class=class="detail-joined__date"> | |
| {{ timeSince(user.createdOn, '--', 'short') }} | |
| </ion-text> | |
| </div> | |
| <div> | |
| <ion-text class="text4"> | |
| {{ $t('UsersPage.UserDetailsModal.subtitles.commonWorkspaces') }} | |
| </ion-text> | |
| </div> |
Max-7
approved these changes
Dec 18, 2023
Ironicbay
force-pushed
the
ms-user-details-modal
branch
3 times, most recently
from
5fd1a1d
to
ca5e388
Compare
NicoTuxx
approved these changes
Dec 18, 2023
fabienSvtr
approved these changes
Dec 18, 2023
Ironicbay
force-pushed
the
ms-user-details-modal
branch
from
ca5e388
to
449a3f8
Compare
Ironicbay
force-pushed
the
ms-user-details-modal
branch
from
449a3f8
to
c31dcbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #5974
Checklist
Before you submit this pull request, please make sure to:
If this PR adds a new feature or fixes a bug:
If this PR is related to GUI: